Port sunsch to use Pydantic instead of configsuite

[berland]

No description provided.

[codecov-commenter]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6c42a88) 86.13% compared to head (da21040) 86.13%.

❗ Current head da21040 differs from pull request most recent head 4c48229. Consider uploading reports for the commit 4c48229 to get more accurate results

Files	Patch %	Lines
src/subscript/sunsch/sunsch.py	98.33%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #641   +/-   ##
=======================================
  Coverage   86.13%   86.13%           
=======================================
  Files          49       49           
  Lines        7052     7047    -5     
=======================================
- Hits         6074     6070    -4     
+ Misses        978      977    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[oyvindeide]

Would add: _ensure_start_refdate as a model validator, something like:

    @model_validator(mode="after")
    def ensure_start_date(self) -> Self:
        if not self.startdate:
            if self.starttime:
                self.startdate = self.starttime
            elif self.refdate:
                self.startdate = self.refdate
            else:
                self.startdate = datetime.date(1900, 1, 1)
        if not self.starttime:
            self.starttime = self.startdate
       if not self.refdate:
            self.refdate = self.startdate
        return self

could potentially also be a pre-validation.

[berland]

Done, as a pre-validation. After-validation was not possible as it will invalidate based on the values given before this after_validator is run.

[berland]

Tried also as after-validation by setting the date fields to be Optional, allowing such an after-validator:

    @model_validator(mode="after")
    def set_date_defaults(self) -> "SunschConfig":
        self.startdate = (
            self.startdate
            or self.starttime
            or self.refdate
            or datetime.date(1900, 1, 1)
        )
        self.starttime = self.starttime or datetime_from_date(self.startdate)
        self.refdate = self.refdate or self.startdate
        return self

This was even prettier but gave uglier changes to the rest of the code as all parts have to handle the Optional fields to make mypy happy. Will stick to the before-validator.

[yngve-sk]

I think in general before-validators are more practical for this kind of argument inference stuff

[yngve-sk]

Style: Could write something like this:

SunschConfig(**{
    "output": "-", 
    "startdate": datetime.date(1900, 1, 1),
    **yaml_config,
    **cli_config
})

instead of defining a default_config and doing .update calls etc

[berland]

thanks, will try

[berland]

Pydantic did not like merging these settings;
E TypeError: ModelMetaclass object got multiple values for keyword argument 'output'

[yngve-sk]

LGTM only some minor comments, as long the "using pre-validators for modifying the model's input dict" pattern works it is fine, would consider if overriding init and doing the input parsing there instead of a validator is a more clean expression of what is being done -- filling in "missing" arguments based on other arguments given. (defaulting startdate to starttime|refdate|datetime.date(1900,1,1), defaulting starttime to startdate, defaulting refdate to startdate)... would question why that logic is there in the first place but that is maybe outside the scope of this PR.

[berland]

Changed from using a data validator to to the transformation to overriding __init__.