Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eclcompress: deprecate providing a keyword regex #632

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

mferrera
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e92301f) 84.72% compared to head (1f53d84) 84.70%.

❗ Current head 1f53d84 differs from pull request most recent head 585242e. Consider uploading reports for the commit 585242e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
- Coverage   84.72%   84.70%   -0.03%     
==========================================
  Files          52       52              
  Lines        7521     7510      -11     
==========================================
- Hits         6372     6361      -11     
  Misses       1149     1149              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mferrera mferrera requested review from alifbe and rnyb November 20, 2023 08:19
Copy link
Collaborator

@rnyb rnyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mferrera mferrera merged commit 47f93ad into equinor:main Nov 20, 2023
4 checks passed
@mferrera mferrera deleted the depr-eclcompress-regex branch November 20, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants