Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Loading indicator on object and variogram result #422

Merged

Conversation

o-jorgensen
Copy link
Contributor

This PR will

  • Add an animated loading indicator to the object- and variogram result pages
  • Minimally improve HTML semantics
  • Fix a typo
  • Set the model page to full height (this is only visible on the loading state, where the gray background would only cover half of the page)

Closes #400

Note: There are still multiple instances of the static "Loading ..." text in the application that could be improved, but I was not able to trigger and test them all.

@o-jorgensen o-jorgensen self-assigned this Dec 27, 2024
@o-jorgensen o-jorgensen changed the title Fix/loading indicator on object and variogram result fix: Loading indicator on object and variogram result Dec 27, 2024
Copy link
Collaborator

@mheggelund mheggelund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mheggelund mheggelund merged commit 81a81b7 into main Jan 2, 2025
5 checks passed
@mheggelund mheggelund deleted the fix/loading-indicator-on-object-and-variogram-result branch January 2, 2025 10:28
@pepm-ci pepm-ci bot mentioned this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading state in application
2 participants