fix: Housekeeping (adjust HTML landmarks, correct a typo, set model p…

…age to full height)
equinor · Dec 27, 2024 · 29ab9bb · 29ab9bb
1 parent 2dfba0c
commit 29ab9bb
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 8 deletions.
diff --git a/src/App.styled.tsx b/src/App.styled.tsx
@@ -1,6 +1,6 @@
 import styled from 'styled-components';
 
-const StyledOutletWrapper = styled.section`
+const StyledOutletWrapper = styled.div`
   height: calc(100% - 128px);
   overflow: auto;
 `;

diff --git a/src/features/HandleModel/SidePane/SidePane.styled.ts b/src/features/HandleModel/SidePane/SidePane.styled.ts
@@ -3,8 +3,8 @@ import styled from 'styled-components';
 import { spacings } from '../../../tokens/spacings';
 import { theme } from '../../../tokens/theme';
 
-export const SidebarWrapper = styled.div`
-  heigth: 100%;
+export const SidebarWrapper = styled.aside`
+  height: 100%;
   max-width: 256px;
 `;
 

diff --git a/src/pages/AddModel/AddModel.styled.tsx b/src/pages/AddModel/AddModel.styled.tsx
@@ -8,7 +8,7 @@ export const PageLayout = styled.div`
   height: 100%;
 `;
 
-export const Content = styled.div`
+export const Content = styled.main`
   display: flex;
   flex-direction: column;
   align-items: flex-start;

diff --git a/src/pages/Browse/Browse.styled.tsx b/src/pages/Browse/Browse.styled.tsx
@@ -1,7 +1,7 @@
 import styled from 'styled-components';
 import { spacings } from '../../tokens/spacings';
 
-export const BrowseWrapper = styled.div`
+export const BrowseWrapper = styled.main`
   column-gap: ${spacings.X_LARGE};
   padding: ${spacings.XXX_LARGE} ${spacings.X_LARGE};
 

diff --git a/src/pages/ModelPages/Model/Model.styled.tsx b/src/pages/ModelPages/Model/Model.styled.tsx
@@ -20,12 +20,15 @@ export const Wrapper = styled.div`
   display: grid;
   grid-template-areas: 'sidebar content';
   grid-template-columns: 16rem 1fr;
+  height: 100%;
 `;
 
-export const ContentWrapper = styled.div`
+export const ContentWrapper = styled.main`
   grid-area: content;
+  display: flex;
+  flex-flow: column nowrap;
 `;
 
-export const SidebarWrapper = styled.div`
+export const SidebarWrapper = styled.aside`
   grid-area: sidebar;
 `;
diff --git a/src/pages/ModelPages/Model/Model.tsx b/src/pages/ModelPages/Model/Model.tsx
@@ -132,7 +132,7 @@ export const Model = () => {
             size={24}
             value={100}
             variant="indeterminate"
-          />{' '}
+          />
           <Typography variant="body_short">Loading, please wait…</Typography>
         </div>
       </Styled.EmptyPage>