Make event handlers more deterministic #1920
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andchiind
added
backend
andchiind
force-pushed
the
1891-deterministic-event-handlers
branch
from
679b070 to
f32f840
Compare
oysand
reviewed
Jan 2, 2025
| ); | ||
| var robot = await RobotService.ReadById(e.RobotId, readOnly: true); | ||
| if (robot == null) | ||
| if (e.Robot == null) |
There was a problem hiding this comment.
Can the robot be required to be a part of the event args so this can be known to never be null?
oysand
reviewed
Jan 2, 2025
| return; | ||
| } | ||
|
|
||
| _startMissionSemaphore.WaitOne(); | ||
| try | ||
| { | ||
| await MissionScheduling.StartNextMissionRunIfSystemIsAvailable(robot); | ||
| await MissionScheduling.StartNextMissionRunIfSystemIsAvailable(e.Robot); |
There was a problem hiding this comment.
rather than passing the entire robot object, would it make sense to only pass the relevant information about the robot needed to start the next mission
oysand
reviewed
Jan 2, 2025
| @@ -573,7 +573,7 @@ private async void OnIsarBatteryUpdate(object? sender, MqttReceivedArgs mqttArgs | |||
| robot.Name | |||
| ); | |||
| EmergencyActionService.SendRobotToDock( | |||
| new RobotEmergencyEventArgs(robot.Id, RobotFlotillaStatus.Recharging) | |||
| new RobotEmergencyEventArgs(robot, RobotFlotillaStatus.Recharging) | |||
There was a problem hiding this comment.
do we need to pass the entire robot object, or can we only pass the relevant informations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1891
Ready for review checklist: