Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧑‍💻add 'use client' to relevant index files #3716

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

oddvernes
Copy link
Collaborator

resolves #3702

it was reported that 'use client' on the main index file did not "inherit" down to sub-components. This pr adds 'use client' to the index of components with sub-components. I don't have a test setup to check if this works so I'll make a dev release for @sebastianvitterso to check

@oddvernes oddvernes deployed to development January 6, 2025 08:34 — with GitHub Actions Active
Copy link
Collaborator

@torleifhalseth torleifhalseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oddvernes
Copy link
Collaborator Author

This did not work, we'll leave this for a bit while @sebastianvitterso does some more research

@sebastianvitterso
Copy link
Contributor

I opened an issue in the Nextjs repo vercel/next.js#74585 so they can help. Seems to be a very strange edge-case we're hitting here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support next.js out-of-the-box
3 participants