Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meck:capture(..., result) #250

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rlipscombe
Copy link
Contributor

See #249

I'm not sure whether we want to deprecate the use of meck_history:result(), so I only changed one of the unit tests to use the changed meck:capture().

Let me know what direction you prefer, and I'll change the PR.

@eproxus
Copy link
Owner

eproxus commented Nov 12, 2024

@rlipscombe Thanks! Since result already exists and has the signature it has, I don't think it is too much of a stretch to allow returning the return value of a call too. What do you think about changing it to return_value instead? That matches the language in the Erlang documentation more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants