New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor JavaScript #67

Open

6 tasks

MatzeKitt opened this issue Apr 11, 2021 · 0 comments

Labels

breaking change enhancement

Milestone

Member

MatzeKitt commented Apr 11, 2021 •

edited

Loading

Use const and let.
Change function names to camelCase.
Use for … of (drop IE11 support).
Use arrow functions
Use properties instead of data attributes for state-related things (see https://jakearchibald.com/2024/attributes-vs-properties/)
Don’t use the global namespace (see Do not polute global JS namespace #182)

The text was updated successfully, but these errors were encountered:

MatzeKitt added enhancement breaking change labels

MatzeKitt added this to the Version 2.0.0 milestone

MatzeKitt mentioned this issue

Do not polute global JS namespace #182

Closed

1 task

kraftner mentioned this issue

Add JS-API to enable/disable embeds #186

Open

1 task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment