Do not polute global JS namespace

[kraftner]

Bug/Problem

There currently are multiple JS functions defined in the global namespace. To make things worse they also have very generic names. They are also taken from stackoverflow which makes it even more likely to have collisions with other peoples code.

• get_cookie
• htmlentities_decode
• remove_cookie
• set_cookie

embed-privacy/assets/js/embed-privacy.js

Lines 286 to 346 in 2cf319a

	/**
	* Get a cookie.
	*
	* @link https://stackoverflow.com/a/24103596/3461955
	*
	* @param {string} name The name of the cookie
	*/
	function get_cookie( name ) {
	var nameEQ = name + '=';
	var ca = document.cookie.split( ';' );
	for ( var i = 0; i < ca.length; i++ ) {
	var c = ca[ i ];
	while ( c.charAt( 0 ) == ' ' ) c = c.substring( 1, c.length );
	if ( c.indexOf( nameEQ ) == 0 ) return c.substring( nameEQ.length, c.length );
	}
	return null;
	}
	/**
	* Decode a string with HTML entities.
	*
	* @param {string} content The content to decode
	* @return {string} The decoded content
	*/
	function htmlentities_decode( content ) {
	var textarea = document.createElement( 'textarea' );
	textarea.innerHTML = content;
	return textarea.value;
	}
	/**
	* Remove a cookie.
	*
	* @link https://stackoverflow.com/a/24103596/3461955
	*
	* @param {string} name The name of the cookie
	*/
	function remove_cookie( name ) {
	document.cookie = name + '=; expires=0; path=/';
	}
	/**
	* Set a cookie.
	*
	* @link https://stackoverflow.com/a/24103596/3461955
	*
	* @param {string} name The name of the cookie
	* @param {string} value The value of the cookie
	* @param {number} days The expiration in days
	*/
	function set_cookie( name, value, days ) {
	var expires = '';
	if ( days ) {
	var date = new Date();
	date.setTime( date.getTime() + ( days * 24 * 60 * 60 * 1000 ) );
	expires = '; expires=' + date.toUTCString();
	}
	document.cookie = name + '=' + ( value || '' ) + expires + '; path=/';
	}

Steps to reproduce

1. Go to the frontend of a site with Embed Privacy enabled
2. Open developer console
3. Start typing e.g. get_ cookie to see that they are defined in the global namespace.

Version

1.7.2

Link

No response

Environment info

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[kraftner]

The easiest solution probably is to wrap the whole file into an Immediately Invoked Function Expression to have everything in its own scope.
I do not expect any breaking changes to be caused by that. If you want I can also offer to create a PR for that.

[MatzeKitt]

This should only affect dev environments with WP_DEBUG enabled, though, since they’re no more global as soon as compiled (there the IIFE is already in use).

Currently, I consider this a minor issue as it doesn’t effect production sites.

However, it’s already planned to refactor the JavaScript in version 2.0 since it’s a breaking change. So I added this to the list of #67.

Thank you for pointing out the problem. 🤗

[kraftner]

Oh, yeah, of course. 🤦‍♂️ Good morning, sorry for the noise. 😀

[MatzeKitt]

No problem, I didn’t have it on the list. Better this way than another. 🙂