Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Nova Deferred Field Support #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tzsk
Copy link

@tzsk tzsk commented Jan 31, 2020

BUG FIX

Nova has the support for Deferred Fields. Meaning, the fields which get handled after the model is saved i.e. created or updated.

For those types of fields, the fill() method on the Field returns a closure. And that closure gets invoked after the Resource Model is saved. Refer to: Laravel\Nova\Http\Controllers\ResourceStoreController:41 & Laravel\Nova\Http\Controllers\ResourceUpdateController:38

Now, the bug is. If you put those types of fields in the Dependency Container it never gets handled.

So, for this package to support all scenarios, just filling the fields is not enough. We have to handle the deferred fields under the field list of Dependency Container (if any).

This PR is an attempt to fix that.

@jkudish
Copy link

jkudish commented Feb 6, 2020

Hi @wize-wiz, I work with @tzsk and I'm wondering if there's any chance you could take a look at this PR and get it merged? We'll have to fork the project otherwise, which I'd love to avoid doing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants