Fix for Nova Deferred Field Support #110
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG FIX
Nova has the support for Deferred Fields. Meaning, the fields which get handled after the model is saved i.e. created or updated.
For those types of fields, the
fill()
method on the Field returns a closure. And that closure gets invoked after the Resource Model is saved. Refer to:Laravel\Nova\Http\Controllers\ResourceStoreController:41
&Laravel\Nova\Http\Controllers\ResourceUpdateController:38
Now, the bug is. If you put those types of fields in the Dependency Container it never gets handled.
So, for this package to support all scenarios, just filling the fields is not enough. We have to handle the deferred fields under the field list of Dependency Container (if any).
This PR is an attempt to fix that.