Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IntegrationTests #1279

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

StefanKruk
Copy link
Collaborator

The "-Dplatformhome" Command Line Property were wrongly populated which leads to errors.
Further the Environment Properties like HYBRIS_BIN_DIR did not substitute the ${platformhome} placeholder.

Signed-off-by: Stefan Kruk [email protected]

@mlytvyn mlytvyn added this to the Release 2024.3.2 milestone Nov 18, 2024
@mlytvyn mlytvyn self-requested a review November 18, 2024 12:51
Copy link
Collaborator

@mlytvyn mlytvyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StefanKruk thank you for your contribution!

@@ -71,6 +70,10 @@ class HybrisJUnitExtension : RunConfigurationExtension() {

val modules: Array<Module> = ModuleManager.getInstance(project).modules
for (module in modules) {
if (module.name.startsWith("CCv2")) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it may not be fully sufficient, please try to use YFacet instead to validate module type.

p.s. it may happen that end-user changed module name via hybris4intellij.properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants