[mob] Minor UX improvement (#2473)

## Description ## Tests
ente-io · Jul 17, 2024 · 5dd8c0a · 5dd8c0a
2 parents 6c4a2a9 + 3554376
commit 5dd8c0a
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 6 deletions.
diff --git a/mobile/lib/generated/intl/messages_en.dart b/mobile/lib/generated/intl/messages_en.dart
diff --git a/mobile/lib/generated/l10n.dart b/mobile/lib/generated/l10n.dart
diff --git a/mobile/lib/l10n/intl_en.arb b/mobile/lib/l10n/intl_en.arb
@@ -1276,5 +1276,6 @@
   "noSystemLockFound": "No system lock found",
   "toEnableAppLockPleaseSetupDevicePasscodeOrScreen": "To enable app lock, please setup device passcode or screen lock in your system settings.",
   "tapToUnlock": "Tap to unlock",
-  "tooManyIncorrectAttempts": "Too many incorrect attempts"
+  "tooManyIncorrectAttempts": "Too many incorrect attempts",
+  "videoInfo": "Video Info"
 }
diff --git a/mobile/lib/ui/viewer/file/video_exif_dialog.dart b/mobile/lib/ui/viewer/file/video_exif_dialog.dart
@@ -1,4 +1,5 @@
 import 'package:flutter/material.dart';
+import "package:photos/l10n/l10n.dart";
 import "package:photos/models/ffmpeg/ffprobe_keys.dart";
 import "package:photos/theme/ente_theme.dart";
 
@@ -29,7 +30,7 @@ class VideoExifDialog extends StatelessWidget {
       data: Theme.of(context).copyWith(dividerColor: Colors.transparent),
       child: ExpansionTile(
         initiallyExpanded: false,
-        title: Text(title, style: getEnteTextTheme(context).largeFaint),
+        title: Text(title, style: getEnteTextTheme(context).body),
         childrenPadding: EdgeInsets.zero, // Remove padding around children
         tilePadding: EdgeInsets.zero,
         collapsedShape: const Border(), // Remove border when collapsed
@@ -43,9 +44,13 @@ class VideoExifDialog extends StatelessWidget {
     return Column(
       crossAxisAlignment: CrossAxisAlignment.start,
       children: [
+        Text(
+          context.l10n.videoInfo,
+          style: getEnteTextTheme(context).large,
+        ),
         _buildInfoRow(context, 'Creation Time', probeData, 'creation_time'),
         _buildInfoRow(context, 'Duration', probeData, 'duration'),
-        _buildInfoRow(context, 'Location', probeData, 'location'),
+        _buildInfoRow(context, context.l10n.location, probeData, 'location'),
         _buildInfoRow(context, 'Bitrate', probeData, 'bitrate'),
         _buildInfoRow(context, 'Frame Rate', probeData, FFProbeKeys.rFrameRate),
         _buildInfoRow(context, 'Width', probeData, FFProbeKeys.codedWidth),
@@ -97,10 +102,12 @@ class VideoExifDialog extends StatelessWidget {
     return ExpansionTile(
       title: Text(
         titleString,
-        style: getEnteTextTheme(context).smallBold,
+        style: getEnteTextTheme(context).small,
       ),
       childrenPadding: const EdgeInsets.symmetric(vertical: 0, horizontal: 4),
-      tilePadding: const EdgeInsets.symmetric(vertical: 4),
+      tilePadding: EdgeInsets.zero,
+      collapsedShape: const Border(), // Remove border when collapsed
+      shape: const Border(),
       children: [
         Column(
           crossAxisAlignment: CrossAxisAlignment.start,

diff --git a/mobile/lib/ui/viewer/file_details/video_exif_item.dart b/mobile/lib/ui/viewer/file_details/video_exif_item.dart
@@ -34,7 +34,7 @@ class _VideoProbeInfoState extends State<VideoExifRowItem> {
   Widget build(BuildContext context) {
     return InfoItemWidget(
       leadingIcon: Icons.text_snippet_outlined,
-      title: "Video Info",
+      title: S.of(context).videoInfo,
       subtitleSection:
           _exifButton(context, widget.file, widget.props?.prodData),
       onTap: _onTap,