add form validation docs #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colepeters
reviewed
Oct 26, 2023
| <enhance-form | ||
| action="/books/${book.key}" | ||
| method="POST"> | ||
| ${'' /* 3. Overall form error messages */} |
There was a problem hiding this comment.
Wondering about the ${ '' … } comments here — were // comments not working?
There was a problem hiding this comment.
Since this is inside a block of HTML I did not want the comment to be rendered as an HTML comment. So I opted for the JS comment inside the literal so it doesn't render to the markup. But I agree it looks weird. If you think I should go with HTML comments here that would be fine.
There was a problem hiding this comment.
Ohhh, clever! I hadn't thought of that. Nice!
colepeters
reviewed
Oct 30, 2023
|
@ryanbethel Just a li'l typo then good to go! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document form validation patterns and the problems loop