Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ships & outfits for the Unfettered #7019

Merged
merged 61 commits into from
Nov 9, 2022

Conversation

Hurleveur
Copy link
Member

@Hurleveur Hurleveur commented Jul 9, 2022


Content (Artwork)

Summary

This PR contains the ships and outfits to be added for part 1 of the campaign (#6416), as suggested by @warp-core.
That way we can do any balancing if needed, and it can make the campaign advance more towards mergeable state.

Note: I removed what I don't have the assets or 2x version of, namely the pistol rifle (that is meant as an easter egg) and the license for which @beccabunny should make a new version of eventually (except if he changed his mind), in the meantime it's just meant as a placeholder, or more if I get the 2x version, which I doubt.
Also I only included the generic new ship and outfits, not the new prototypes that are in the campaign.

Also expect a bit of spoilers. The good kind of spoilers.
I'll be adding scenes for seeing the ship in game shortly.

Important: feedback is required and appreciated, this is not the final form of the weapon's stats or the ship's.

Details

Sea scorpion:
hai sea scorpion
This is a medium warships (the Uhai don't have any) meant to be able to field a good amount of pulse, ion, and be an agile harasser.
sea scoorpion

These new weapons won't be easily accessible for part1; you'll only be able to get a few. Only when the Uhai will get control of Wanderer shipyards will they be able to produce more of these. So they're supposed to punch a bit higher than their tier, as these are highly unstable prototypes that they invested a lot into, and which will be refined later.

New ionic weapons:
hai ionic blaster
hai ionic turret
These new weapons are meant to be (like all UHai weapons) highly unstable and not very efficient but still devastating. They lack the range of the ion cannon but make up for it with higher dps.

Video showing how the tripulse & ionic work in game.
tripulse&ionic.zip

Tripulse shredder:
tripulse shredder
Now this is by far my favourite. It is meant to bring new possibilities to ES, with hit and run tactics made possible with its high damage in bursts. The sea scorpion is meant to be able to carry 4 of these, for when the time comes.

Value Detector:
value detector
It has come to my attention that the UHai, whilst being depicted as raiders and pillagers, didnt even have a scanner for it. Worst they don't even sell a simple cargo scanner at their homeworld (but that'll be handled by the main campaign)
This outfit is meant to solve that, it tells you the value of the enemy's cargo and also how well defended it is; if taking the ship is an option with its crew. But most importantly it lets you know what kind of energy they're running on so you know if you can disable them and quickly steal that precious cargo before they can get away.

This also adds the Sea Scorpions to the shipyard to be available for buying by anyone, same for the value detector.
It also adds the sea scorpion to fleets.

Testing

Here is a savefile with a sea scorpion that has access to all the new weapons, and the value detector; in the stock or equipped on the ship. It's in Hai space, if you want to test how it works go ahead. I also recommend trying out the "full tracker pod" version for that ship, with its agility it can be quite strong.
Emile Lancer.txt

Artwork Checklist

  • I updated the copyright attributions, or decline to claim copyright of any assets produced or modified
  • I created a PR to the endless-sky-assets repo with most assets from this PR 59
  • I created a PR to the endless-sky-high-dpi repo with the @2x versions of these art assets: {{272}}

@Hurleveur
Copy link
Member Author

I have no experience with doing a campaign so feel free to tell me what I should or should not include here (usages or ship; only the things that are there without the campaign... I have 0 experience)

@Zitchas
Copy link
Member

Zitchas commented Jul 9, 2022

I haven't really dug into running the numbers; but on the surface it looks like an interesting set of things. They add some capabilities, and sounds like the sorts of things that would fit into an Unfettered campaign.

I'm a little concerned they might not shift enough, though. The differences between the ion cannon and the ion blaster are slight, at least numerically. If the intent is to create a blaster style version of the ion cannon, it might need to shift the balance a bit farther.

@Hurleveur
Copy link
Member Author

Hurleveur commented Jul 9, 2022

Later on in the campaign the player will receive the choice to improve one side of the gun, you're right it seems too similar rn, also I'd like to make the turret smth more than just the "double version of the gun that follows enemies" (with, say, a bigger focus on ion values, for example)
But I suck at balancing stuff precisely because of lack of experience so do give any suggestions you may have, currently these stats are not the final ones they're really meant to be a stupidly unstable prototype that'll get refined later.

edit: also the Sea Scorpion feels too weak to me, but idk much about balance as I said
the tripulse shredder feels really good however

@EjoThims
Copy link
Member

EjoThims commented Jul 9, 2022

I'm a little concerned they might not shift enough, though. The differences between the ion cannon and the ion blaster are slight, at least numerically. If the intent is to create a blaster style version of the ion cannon, it might need to shift the balance a bit farther.

Part of it was to try and make sure it wasn't significantly stronger (to avoid being unbalanced or seen as power creep). Even though it -is- meant to be a more modern design than the ancient ion cannon, there's also the large size difference to take into account; they fill different roles/sizes of ships.

@roadrunner56 roadrunner56 added the content Issues and PRs about adding new game content (such as missions) without making code changes label Jul 9, 2022
I tried to make the turret more ion focus and the blaster damage focus
note: this still needs a lot of balancing, opinions are welcome
nerfed it as suggested by Arachi
@Hurleveur
Copy link
Member Author

I have just made some changes to the ionic weapons after thinking a bit about it (thx Zitchas for the tips).
Now they have more of a role; the Blaster was done first in order to make as many of them fit on a SB as possible, disregarding stability, range, and ion.
Then, when doing the turrets, they had more experience and tried a more stable version of the ion; meaning less damage to the shields and more actual ion.

These weapons should convey that these are prototypes, and that they evolved; I don't like turrets that are just faster shooting guns.

Hurleveur added 2 commits July 9, 2022 22:14
comparing it to the lightning bug it just felt too weak - and not uhai enough
it needs to do enough ion to actually be noticed
@Hurleveur
Copy link
Member Author

Some updates: soon there will be new visuals for the ionic blaster & turret.
Also I buffed the sea scorpion's shields a bit (+2000) because, even though it is meant to be a very quick and easily produced ships made by UHai, its design was mostly done back in the days of the Korath attacks by the Hai (looking for a ship fast enough to keep the raiders busy with tracker pods until SB arrive)
Otherwise it felt like a really weak medium warship; comparing it to the water bug which is a freighter and has 150 extra cargo, my idea is that they just removed cargo capacity from the original design and added some more shields generators instead (which explains why its the only Hai ship with so "little" cargo, 45)

please watch the video of how useless ion was before this buff
also dont compare it to the ion cannon that one didn't get buffed with the battery upgrade
@Hurleveur
Copy link
Member Author

Two things remain to address, in my opinion: are the ionic strong enough, and should they be made bigger?
I improved the ionic values because you couldn't even power down a ship below your size before you actually disable it first, by what little damage is done. (okay it was Hai so its meant to be resilient to it but batteries just got buffed and ion didn't follow)
I'm going to open a PR to buff the ion cannon in reaction to #6783

@EjoThims
Copy link
Member

Ion got the firing interference behavior when batteries got buffed. It doesn't drain as much (relative to new totals), but instead now causes interference even when not completely draining someone.

Hurleveur and others added 2 commits July 13, 2022 21:20
shouldn't be too strong anymore
they are used for the prototype ionic blaster & turrets, and made by Saugia

Co-Authored-By: Saugia <[email protected]>
@Hurleveur
Copy link
Member Author

Hurleveur commented Jul 23, 2022

I added a savefile to test the new weapons & the ship (in which you have a sea scorpion & the different guns).
The ionic blasters/turrets now have improved sprites and sounds for the shots.

Feedback is really needed to know if the weapons are in a good state right now; too weak or too strong, and how the look of them could be improved. I have done all that I can by myself on that end.

I added additional description on this side but it can wait a bit before being fixed

Co-Authored-By: Jack W. <[email protected]>
data/hai/hai outfits.txt Outdated Show resolved Hide resolved
data/hai/hai outfits.txt Outdated Show resolved Hide resolved
data/hai/hai outfits.txt Outdated Show resolved Hide resolved
data/hai/hai outfits.txt Outdated Show resolved Hide resolved
Copy link
Member

@roadrunner56 roadrunner56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing.

data/hai/hai outfits.txt Outdated Show resolved Hide resolved
woops
anyway this feels just right
@Saugia Saugia self-assigned this Oct 29, 2022
data/hai/hai outfits.txt Outdated Show resolved Hide resolved
data/hai/hai outfits.txt Outdated Show resolved Hide resolved
data/hai/hai outfits.txt Outdated Show resolved Hide resolved
data/hai/hai outfits.txt Outdated Show resolved Hide resolved
data/hai/hai outfits.txt Show resolved Hide resolved
data/hai/hai outfits.txt Outdated Show resolved Hide resolved
data/hai/hai ships.txt Outdated Show resolved Hide resolved
data/hai/hai ships.txt Outdated Show resolved Hide resolved
data/hai/hai ships.txt Outdated Show resolved Hide resolved
data/hai/hai ships.txt Outdated Show resolved Hide resolved
@Hurleveur
Copy link
Member Author

Hurleveur commented Oct 31, 2022

Until now there were no Unfettered outfits in the game. Indeed Hai ships dont have much going for them in the description but the Unfettered would be happy to proudly talk about these weapons and ships, and thats the idea I would like of them in the game.
Hai outfits are efficients and they dont really need an introduction, Uhai want to do things differently, their outfits and ships dont have everything written in the stats

Edit: to be clear, I wouldnt mind it being more condensed, or remove some parts of it but I dont want to remove all of it either

@Saugia Saugia removed their assignment Oct 31, 2022
@Hurleveur
Copy link
Member Author

Hurleveur commented Oct 31, 2022

I'll include these stories about the weapons etc into the campaign itself, when the time is right

Edit: also I think all feedback is addressed?

Copy link
Collaborator

@Saugia Saugia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like all feedback from Grey and Anarchist has been addressed and no new changes have been made to require more. Artwork looks good here too. On behalf of this, I'm going to approve this PR. Just be sure to get new sprites for the Ionic Turrets soon, preferably before the Uhai Campaign PR (or for that PR).

also this dimension works for the 2x and may as well make it a tiny bit smaller
@Hurleveur
Copy link
Member Author

Was a small quirk with the size - the high dpi hadnt been updated right, and this one was said to "possibly look blurry" by the game.
That has now been addressed, without a need to change the asset files for the tripulse shredder.

@Saugia Saugia dismissed Anarchist2’s stale review November 9, 2022 02:17

Feedback addressed.

@Saugia
Copy link
Collaborator

Saugia commented Nov 9, 2022

Since all feedback was addressed for both Anarchist's and Grey's reviews, and this PR has approvals from multiple trusted individuals in each separate branch, I'm approving this PR and moving forward with merging it.

@Saugia Saugia merged commit 1f3653b into endless-sky:master Nov 9, 2022
@Hurleveur Hurleveur deleted the new-unfet-stuff branch November 9, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artwork Everything related to images, sprites, and graphics content Issues and PRs about adding new game content (such as missions) without making code changes text - short Content that contains short blocks of text such as jobs, small missions, descriptions, etc.
Projects
Development

Successfully merging this pull request may close these issues.

9 participants