Modify application_state at _raise_on_disconnect

[osangu]

Summary

In my opinion, even when the websocket is closed by the client, the state should be changed to DISCONNECTED.
This way, it can be handled more easily by users.

Checklist

• I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
• I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
• I've updated the documentation accordingly.

[Kludex]

But we do have client_state...

[Kludex]

Also, why are you using those states in your application?

[osangu]

Oh.. I didn't know about client_state, so using like below code .
I apologize for making PR with light knowledge and finally waste your time.

Once again, I'm really sorry.

@socket_router.websocket('/ws')
async def knowledge_chat(
        websocket: WebSocket
):
    already_disconnected = False
    try:
        await service(websocket)

    except fe.WebSocketDisconnect:
        already_disconnected = True

    finally:
        still_connected = websocket.application_state == WebSocketState.CONNECTED

        if not already_disconnected and still_connected:
            await fe_websocket.close()

[Kludex]

I don't recommend using those states. You should rely on the WebSocketDisconnect.

[osangu]

May I kindly ask if the reason you recommend manage through exception handling is to enable immediate processing of the connection? If that’s not the case, I would be truly grateful if you could explain the other reasons.

[Kludex]

The reason is that application_state and client_state are meant to be private, even if there's no underscore as prefix. 😅

[osangu]

I understood!
Really appreciate for you kind comment and sorry again : )
Have a nice day!!

[Kludex]

No need to apologize, all good. :)

Thanks for closing the PR.