Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-171: Update webdriverio to version 9 #160

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from

Conversation

adrian-cocoara-lgp
Copy link
Contributor

@adrian-cocoara-lgp adrian-cocoara-lgp commented Sep 16, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • I have run automated testing and it is passed
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Updated webdriverio and its subdependencies to version 9

Resolution

Additional Considerations

Release blog: https://webdriver.io/blog/2024/08/15/webdriverio-v9-release

- Existing known bug on Chrome needs to be handled in order for this PR to be reviewed: webdriverio/webdriverio#13440

Links

WRR-171

Comments

Enact-DCO-1.0-Signed-off-by: Adrian Cocoara [email protected]

utils/Page.js Outdated Show resolved Hide resolved
}
}
}
skipSeleniumInstall: offline
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Since webdriverio handles driver management, I only left the offline option active.

"@wdio/static-server-service": "^7.33.0",
"@wdio/cli": "^9.2.12",
"@wdio/dot-reporter": "^9.2.2",
"@wdio/local-runner": "9.2.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: @wdio/local-runner is set to a fixed version because of a bug introduced in version 9.2.2 and above which blocks running tests with chromedriver 120
Error: [chrome-headless-shell 120.0.6099.109 linux #0-51] waitUntil condition timed out after 10000ms
[chrome-headless-shell 120.0.6099.109 linux #0-51] Error: waitUntil condition timed out after 10000ms

debuggerAddress: `${process.env.TV_IP}:9998`
}
},
'wdio:enforceWebDriverClassic': true
Copy link
Contributor Author

@adrian-cocoara-lgp adrian-cocoara-lgp Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w3c: false enforces wdio to use JSON Wire Protocol which has been removed in version 9: https://webdriver.io/blog/2024/08/15/webdriverio-v9-release#removal-of-json-wire-protocol-commands
I have added 'wdio:enforceWebDriverClassic': true to use Webdriver Classic Protocol
Setting this value to false, wdio will use WebdriverBiDi Protocol which does not work right now with remote debugger

debuggerAddress: `${process.env.TV_IP}:9998`
}
},
'wdio:enforceWebDriverClassic': true
Copy link
Contributor Author

@adrian-cocoara-lgp adrian-cocoara-lgp Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w3c: false enforces wdio to use JSON Wire Protocol which has been removed in version 9: https://webdriver.io/blog/2024/08/15/webdriverio-v9-release#removal-of-json-wire-protocol-commands
I have added 'wdio:enforceWebDriverClassic': true to use Webdriver Classic Protocol
Setting this value to false, wdio will use WebdriverBiDi Protocol which does not work right now with remote debugger

Comment on lines +115 to +117
// WebdriverIO v8.14 and above downloads and uses the latest Chrome version when running tests.
// Uncomment `browserVersion` line when running ui-tests locally to match chromedriver version running in CI/CD environment.
// TODO: Update this version when chromedriver version in CI/CD is updated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use a multiline comment for these 3 lines to differentiate real comments from commented code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants