Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow edit headings' anchor ids #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

allow edit headings' anchor ids #11

wants to merge 2 commits into from

Conversation

dest81
Copy link

@dest81 dest81 commented Feb 5, 2023

This PR is intended to solve issue.

PR includes:

  • ability to edit id of the header (header can have auto id or custom id entered by user)
  • prefilling promt input with anchor value when edit existing anchor

@dest81
Copy link
Author

dest81 commented Mar 24, 2023

@jacobtoppm any chance this PR can be reviewed?

emilytoppm
emilytoppm reviewed Mar 24, 2023
View reviewed changes
wagtail_draftail_anchors/static_src/wagtaildraftailanchors/js/wagtail_draftail_anchor.js Outdated
onRemove(e) {
e.preventDefault();
e.stopPropagation();
this.setState({ showTooltipAt: null });
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't actually remove it, which feels confusing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, I will check and let you know soon

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed. Now onRemove sets anchor to null, which means that slugified header text will be set as id. Also I have renamed button to 'Reset'.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobtoppm will you have time to have a look?

@dest81
Copy link
Author

dest81 commented Jun 29, 2023

any chance this PR can be approved/reviewed?

@dest81
Copy link
Author

dest81 commented Jul 27, 2023

@jacobtoppm any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilytoppm emilytoppm emilytoppm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dest81 @emilytoppm