Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Plot::link_cursor to accept impl Into<Vec2b> #66

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow Plot::link_cursor to accept impl Into<Vec2b> #66

wants to merge 2 commits into from

Conversation

jetuk
Copy link

@jetuk jetuk commented Jan 8, 2025

Updates the link argument to the impl Into<Vec2b> to be consistent with link_axis. This makes it slightly cleaner to use.

  • I have followed the instructions in the PR template

@jetuk
Allow Plot::link_cursor to accept impl Into<Vec2b>
e6d6a6c 
Updates the `link` argument to the `impl Into<Vec2b>` to be
consistent with `link_axis`. This makes it slightly cleaner
to use.
bircni
bircni approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@bircni bircni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more points with the same Vec2b
Could you change these too?

@jetuk
Copy link
Author

jetuk commented Jan 8, 2025

Done, I think!

bircni
bircni approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@bircni bircni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bircni bircni bircni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jetuk @bircni