Add PlotUi::add_item(Box<dyn PlotItem>)
#51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeformstu
changed the title
Box<dyn PlotItem> directly to a plot.
bircni
suggested changes
Dec 4, 2024
| @@ -126,6 +126,11 @@ impl PlotUi { | |||
| self.items.push(Box::new(item)); | |||
| } | |||
|
|
|||
| /// Add an arbitrary item. | |||
There was a problem hiding this comment.
A test for that or an example would be nice
emilk
added
enhancement
emilk
approved these changes
Dec 17, 2024
emilk
changed the title
Box<dyn PlotItem> directly to a plot.PlotUi::add_item(Box<dyn PlotItem>)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fn add_boxed(&mut self, Box<dyn PlotItem>)method toPlotUi. #53We have a somewhat unique setup in which we use dioxus for state management and egui for all of the underlying component rendering. When passing attributes through dioxus we have to cast the incoming type which requires that the trait objects be "object safe".
PlotItemis not object safe, so we can't pass it through directly. But we also cannot pass in our own trait which has a method such asfn as_egui_plot_item(&self) -> impl PlotItembecause that is also not object safe so instead we have a trait which has a methodfn as_egui_plot_item(&self) -> Box<dyn PlotItem>. This cannot be passed to the existingfn add(&self, impl PlotItem)method becauseBox<dyn PlotItem>does not satisfy theimpl PlotItemargument but since theplot_itemsare stored asVec<Box<dyn PlotItem>>I've added this method to give access to insert directly.