Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the Gradle wrapper to 8.7 #18

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Upgrade the Gradle wrapper to 8.7 #18

merged 2 commits into from
Apr 26, 2024

Conversation

dmikurube
Copy link
Member

No description provided.

@dmikurube dmikurube added this to the v0.11.5 milestone Apr 25, 2024
@dmikurube dmikurube requested a review from a team as a code owner April 25, 2024 08:59
Copy link
Member

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR relates to "Upgrade the Gradle wrapper to 8.7"?

Base automatically changed from actions-macos-13 to main April 26, 2024 01:46
@dmikurube
Copy link
Member Author

Ah, yes, 526b783 is the exact commit to upgrade Gradle, and the next 4e6cf74 is required to make it happen.

For some reasons, Gradle judged that this project's compileTestJava and checkstyleTest somehow used the result of jar, and recent Gradle requires us to declare such dependencies explicitly.

You can see the error message at: https://github.com/embulk/embulk-parser-csv/actions/runs/8829820651/job/24241673277

@hiroyuki-sato
Copy link
Member

@dmikurube Thanks LGTM👍

@dmikurube
Copy link
Member Author

Thanks!

@dmikurube dmikurube merged commit 29cab3c into main Apr 26, 2024
3 checks passed
@dmikurube dmikurube deleted the gradle-8.7 branch April 26, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants