Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide correct types when using cjs with moduleResolution:nodenext #79

Merged
merged 2 commits into from
Sep 21, 2024
Merged

Provide correct types when using cjs with moduleResolution:nodenext #79

merged 2 commits into from
Sep 21, 2024

Commits on Sep 21, 2024

  1. Provide correct types when using cjs with moduleResolution:nodenext 

    When typescript is using moduleResolution:nodenext, our d.ts file is always treats as ESM due to our `type: "module"` in package.json.

But when we're actually providing a cjs implementation, we need typescript to see a cjs declaration file as well.
    @ef4
    ef4 committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    96b939a View commit details
    Browse the repository at this point in the history

  2. pumping lock, dropping unused dep, and improving attw check

    @ef4
    ef4 committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    b2abf50 View commit details
    Browse the repository at this point in the history