Refactor import insertion code into its own module #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ultimately the goal is to fix embroider-build#71 (which this commit does *not* do) While working on that I decided to refactor the existing import related code and add some commentary to help others understand how it works. This just moves code around without changing behavior.
chancancode
commented
Mar 1, 2024
| @@ -29,7 +29,7 @@ swc_ecma_codegen = { git = "https://github.com/ef4/swc.git", branch = "content-t | |||
| swc_ecma_ast = { git = "https://github.com/ef4/swc.git", branch = "content-tag" } | |||
| swc_ecma_visit = { git = "https://github.com/ef4/swc.git", branch = "content-tag" } | |||
| swc_ecma_utils = { git = "https://github.com/ef4/swc.git", branch = "content-tag" } | |||
| swc_ecma_transforms = { git = "https://github.com/ef4/swc.git", branch = "content-tag" } | |||
| swc_ecma_transforms_base = { git = "https://github.com/ef4/swc.git", branch = "content-tag" } | |||
There was a problem hiding this comment.
This change isn't strictly necessary here, but the hygiene, resolver etc are all actually defined in swc_ecma_transforms_base and just re-exported from swc_ecma_transforms. There are some extra stuff (renamer, etc) that I may need to actually fix #71 so keeping it here.
chancancode
commented
Mar 1, 2024
| template_identifier: Ident, | ||
| found_it: Option<&'a mut bool>, | ||
| pub has_template_tags: bool, |
There was a problem hiding this comment.
Inverted the awaked mut pointer passing, and instead make the Transformer expose this field, the caller is free to read it
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimately the goal is to fix #71 (which this commit does not do)
While working on that I decided to refactor the existing import related code and add some commentary to help others understand how it works. This just moves code around without changing behavior.