-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use local ember-cli instead of global #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you be more explicit about what you mean by "in some environments", the tests here should be covering the case of local installation
My work machine, which is using bash (not zsh), and volta. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
in some shell environments,
execa
withember
as the first argument was attempting to use the global installation (which may not exist!)In this PR, I explicitly point at the local copy of ember-cli, which should be more robust / cross-env.