Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local ember-cli instead of global #88

Merged
merged 6 commits into from
Sep 27, 2024
Merged

Use local ember-cli instead of global #88

merged 6 commits into from
Sep 27, 2024

Conversation

NullVoxPopuli
Copy link
Collaborator

in some shell environments, execa with ember as the first argument was attempting to use the global installation (which may not exist!)

In this PR, I explicitly point at the local copy of ember-cli, which should be more robust / cross-env.

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you be more explicit about what you mean by "in some environments", the tests here should be covering the case of local installation

tests/default.test.mjs Outdated Show resolved Hide resolved
@NullVoxPopuli
Copy link
Collaborator Author

mean by "in some environments", the tests here should be covering the case of local installation

My work machine, which is using bash (not zsh), and volta.

tests/helpers.mjs Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@mansona mansona merged commit 2fb32d8 into main Sep 27, 2024
2 checks passed
@mansona mansona deleted the use-local-ec branch September 27, 2024 17:52
@github-actions github-actions bot mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants