add regression tests for initialisers #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
force-pushed
the
initializer-tests
branch
from
c9f735d
to
bb60534
Compare
mansona
force-pushed
the
initializer-tests
branch
from
bb60534
to
510a5b0
Compare
mansona
changed the title
BlueCutOfficial
approved these changes
Jun 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test covers a case where our initialisers weren't running because of a timing change during the entrypoint loading process. embroider-build/embroider#2006 actually fixes some of the worst problems with this timing problem and probably fixed our issues with initializers 🎉
Fixes #20