[stm32] [timer] [qei] allow configuration of pull-up/down internal re… #3728
+103
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirbaio
reviewed
Jan 5, 2025
leehambley
force-pushed
the
stm32-qei-allow-pupd
branch
6 times, most recently
from
f5d0a13 to
0e924f7
Compare
…sistors on QeiPin Refactor STM32 QEI to use Config struct to emulate UART peripheral and allow config of internal pull-up and -down, and enable setting encoder mode. Warn: Breaking API change So far as possible this is sympathetic to how I understood the UART module/peripheral. I kept things minimally configurable and future prood at the expense of a breaking API change by removing the QeiPin. I kept as much type discrimination code as I could, the specific generic traits about Channel1Pin and Channel2Pin from the timer parent module, and keeping owned references to the pins. I _removed_ some of the use of PhantomData as my naïve reading of the code leads me to believe it's not necessary now, and my breadboarded EC11 encoder toy works with all combinations of PU/PD and different counter modes. Thanks for taking the patch. boop
leehambley
force-pushed
the
stm32-qei-allow-pupd
branch
from
0e924f7 to
56a0294
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sistors on QeiPin
Adjusts the macros for impl<'d, T: GeneralInstance4Channel> QeiPin<'d, T, $channel> to take a 2nd argument which pullup/down should be active for the pins.
Related to #3721 (comment)
This may not be ready to merge yet. I certainly would appreciate feedback from upstream.
I verified this works with a Bluepill clone and a Nucleo F031K6.