Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RP235x: Add the new FJOIN_RX_xxx options #3369

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

pferreir
Copy link
Contributor

This requires changes in pio too if we want the example to work (ping @CBJamo). Probably a new release?

@CBJamo
Copy link
Contributor

CBJamo commented Sep 23, 2024

Build error can be fixed by depending on pio-rs from this pr: rp-rs/pio-rs#66

@pferreir pferreir force-pushed the add-rxf-putget branch 6 times, most recently from e27918f to a13f24b Compare September 24, 2024 18:07
@Dirbaio
Copy link
Member

Dirbaio commented Oct 13, 2024

should we wait for rp-rs/pio-rs#66 before merge? I see there's still quite a bit of discussion there.

@CBJamo
Copy link
Contributor

CBJamo commented Oct 14, 2024

I think we should wait. It's not clear if the pio-rs pr will need to change more or not. This pr is also out of sync with the current state of that pr.

@Dirbaio Dirbaio marked this pull request as draft October 14, 2024 08:45
@pferreir
Copy link
Contributor Author

Removed the rp2350 flags in pio packages. Anything else?

@pferreir
Copy link
Contributor Author

I think this kind of got forgotten. Is this PR still relevant?

@Dirbaio
Copy link
Member

Dirbaio commented Dec 29, 2024

afaict it's still waiting on rp-rs/pio-rs#66

@pferreir
Copy link
Contributor Author

pferreir commented Dec 29, 2024 via email

@Dirbaio Dirbaio force-pushed the add-rxf-putget branch 2 times, most recently from 9625716 to 9f740d8 Compare January 15, 2025 00:55
@Dirbaio Dirbaio marked this pull request as ready for review January 15, 2025 01:07
@Dirbaio Dirbaio added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@Dirbaio Dirbaio merged commit 4d9b279 into embassy-rs:main Jan 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants