Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests needing a wm #1

Merged
merged 12 commits into from
Oct 10, 2023
Merged

Fix tests needing a wm #1

merged 12 commits into from
Oct 10, 2023

Conversation

Bauumm
Copy link
Contributor

@Bauumm Bauumm commented Oct 10, 2023

Just added a WM to the pipeline, then realized that all maximize and minimize tests need some delay and added that.

The love.window.restore() test doesn't pass because the current test delay system can't wait twice without making for very ugly code (I looked into trying to put coroutines in there, but your test calling code isn't exactly the most readable code I've ever seen so I assume you'll have an easier time implementing coroutines than me).

The love.window.getPosition() test passed before but doesn't now after i merged your newest changes, not sure what exactly broke it.

@Bauumm
Copy link
Contributor Author

Bauumm commented Oct 10, 2023

Apparently pipelines in PRs are lacking some permissions. Look at the actions tab in my fork if you want to see the actual results.

@ellraiser
Copy link
Owner

ah nice one!
yeah dont worry about the workflows, seems to happen with the love-test PR to love too

makes sense RE delay - in hindsight probably could of just added the same delays the max methods had to the min methods and it might of just worked without a wm, but I think it's best to have it setup properly with a wm to avoid any future crap we might come across

@ellraiser ellraiser merged commit 462f8c6 into ellraiser:main Oct 10, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants