-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: host I/O access using a Hybrid VFS #495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dario Valdespino <[email protected]>
darvld
added
module:graalvm
Modules, changes, and issues relating to GraalVM
feature
Large PRs or issues with full-blown features
🚧 WIP
Works-in-progress. Blocks merge
🧪 labs
Experimental work
vfs
Issues and PRs relating to virtual file system (VFS) features
module:cli
CLI module issues and features
labels
Nov 1, 2023
github-actions
bot
added
platform:jvm
PRs and issues relating to JVM support.
and removed
module:graalvm
Modules, changes, and issues relating to GraalVM
labels
Nov 1, 2023
Signed-off-by: Dario Valdespino <[email protected]>
darvld
force-pushed
the
feat/hybrid-vfs
branch
from
November 2, 2023 18:48
66a26a4
to
cddb8c9
Compare
Signed-off-by: Dario Valdespino <[email protected]>
darvld
force-pushed
the
feat/hybrid-vfs
branch
from
November 2, 2023 22:17
cddb8c9
to
29cdd90
Compare
Signed-off-by: Dario Valdespino <[email protected]>
darvld
force-pushed
the
feat/hybrid-vfs
branch
from
November 2, 2023 23:57
29cdd90
to
8f5fbeb
Compare
Signed-off-by: Dario Valdespino <[email protected]>
sgammon
reviewed
Nov 3, 2023
sgammon
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
Large PRs or issues with full-blown features
🧪 labs
Experimental work
module:cli
CLI module issues and features
platform:jvm
PRs and issues relating to JVM support.
vfs
Issues and PRs relating to virtual file system (VFS) features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new experimental "Hybrid" VFS implementation that allows reads to fall back to the host file system if the in-memory bundles cannot satisfy the request. While basic, this implementation unlocks important features:
require
/import
) can now be used as long as--host:allow-io
is enabled.@intrinsics
and related packages are now possible.fs
Node.js intrinsic can finally be implemented thanks to host I/O support.Closes #463