Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit bool to int conversion for Dialog return value. #1076

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

antonsoroko
Copy link

Description

for bug found in #1075 :

When authorizing Trakt after entering the code, Elementum notifies that Trakt has been successfully authorized, however the authorization screen does not go away after authorizing. If you hit OK or back a message comes up saying Trakt authorization cancelled. But after opening it seems it is authorized.

we returned wrong value in python thus we always showed error in golang.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Translation

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@antonsoroko antonsoroko marked this pull request as ready for review October 11, 2024 14:34
@elgatito
Copy link
Owner

Do not know how it worked before...

@elgatito elgatito merged commit 7433a97 into elgatito:master Oct 18, 2024
@antonsoroko
Copy link
Author

@elgatito code used return value from Dialog() only for this trakt auth. and it is UI-only issue, it did not affect the auth process. it just showed confusing error message even if everything was ok.

@antonsoroko antonsoroko deleted the fix-dialog-retval branch October 18, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants