Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: project config compatibility #44

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

sacha-c
Copy link
Collaborator

@sacha-c sacha-c commented Dec 23, 2024

This backwards-compatible config key was lost when migrating the config package.

@sacha-c sacha-c requested a review from scastlara as a code owner December 23, 2024 13:49
@github-actions github-actions bot added the fix label Dec 23, 2024
Copy link
Collaborator

@scastlara scastlara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/config/project.go Show resolved Hide resolved
@sacha-c
Copy link
Collaborator Author

sacha-c commented Dec 24, 2024

Just thought: to match sheriff configuration maybe we should change the project-level config to

[report.to]
slack-channels = ["the-slack-channel"]

instead of currently

report-to-slack-channel = "the-slack-channel"

@scastlara
Copy link
Collaborator

Just thought: to match sheriff configuration maybe we should change the project-level config to

[report.to]

slack-channels = ["the-slack-channel"]

instead of currently

report-to-slack-channel = "the-slack-channel"

One day we will finish with the config and API redesign

@sacha-c sacha-c merged commit 62529b5 into elementsinteractive:main Dec 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants