Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IconCollection #60

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Use IconCollection #60

merged 4 commits into from
Oct 11, 2024

Conversation

alainm23
Copy link
Contributor

Separating the list of icons in a new class.

@alainm23 alainm23 requested a review from a team October 11, 2024 19:37
danirabbit
danirabbit requested changes Oct 11, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add new files to POTFILES, otherwise looks good!

@alainm23
Copy link
Contributor Author

I always forget 😅️

danirabbit
danirabbit reviewed Oct 11, 2024
View reviewed changes
po/POTFILES Outdated Show resolved Hide resolved
@alainm23 alainm23 requested a review from danirabbit October 11, 2024 19:55
danirabbit
danirabbit approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks :)

@danirabbit danirabbit enabled auto-merge (squash) October 11, 2024 19:56
@danirabbit danirabbit merged commit 8b2f93d into main Oct 11, 2024
3 checks passed
@danirabbit danirabbit deleted the alain/icon-collection branch October 11, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alainm23 @danirabbit