-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppInfoView: replace combobox with dropdown #2117
Conversation
6d20739
to
4052113
Compare
3dfd819
to
438edfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as it should however when clicking the dropdown button its background becomes transparent so that it has the banner background color
@leolost2605 fixed! Just a reminder, you need to do |
@leolost2605 can I get a re-review? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry kinda forgot about this 😔
LGTM!
Knocks out a couple deprecation warnings by using dropdown and Glib.ListStore