Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sass build system #2116

Merged
merged 9 commits into from
Feb 22, 2024
Merged

Add Sass build system #2116

merged 9 commits into from
Feb 22, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Feb 15, 2024

This adds a fancy scss build system for our styles and moves everything to it. Eliminates a whole bunch of style provider stuff

@danirabbit danirabbit requested a review from a team February 15, 2024 03:05
@danirabbit danirabbit force-pushed the main branch 2 times, most recently from 6d20739 to 4052113 Compare February 16, 2024 15:56
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT this looks the same as main. I can't really comment on code and best practices though because I'm not really good at CSS :)
Nice deprecation cleanup!

@danirabbit danirabbit merged commit 66783eb into main Feb 22, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/scss branch February 22, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants