-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix matrix-widget-api version in package.json #28453
Fix matrix-widget-api version in package.json #28453
Conversation
I'm a bit confused here; are you saying that if I |
Yes, exactly. |
That doesn't happen for me. Also the CI would have failed if yarn.lock was modified? |
matrix-js-sdk#develop now depends on matrix-widget-api^v1.10.0, so update the lockfile to match that.
bcd2dca
to
1deb122
Compare
Interesting, the lockfile was getting updated for me when I filed this, but not anymore. I updated the commit message to reflect that. I'm not sure if CI fails on lockfiles getting modified, but workflows do tend to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
matrix-js-sdk#develop now depends on matrix-widget-api^v1.10.0, so update the lockfile to match that. A yarn install would update the lockfile otherwise.
The correct version was reverted by #28430.
Signed-off-by: Andrew Ferrazzutti [email protected]
Checklist
public
/exported
symbols have accurate TSDoc documentation.