Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outstanding UX issues with replies/mentions/keyword notifs #28270

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

taffyko
Copy link

@taffyko taffyko commented Oct 22, 2024

This is a continuation of PR #85 from the now-incorporated matrix-react-sdk, see the discussion there.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Purpose

For the "Modern" layout, a bright stripe has been added to the left edge of the highlighted-message background to make mentions/notifications more visible, in the spirit of element-hq/element-meta#1476.
EDIT: This addition has been dropped from this PR, as it needs additional work to adhere to the Compound design system guidelines — I believe it would be best for me to address it in a follow-up PR instead.
For now, disregard the highlighted left edge that appears in the "After" screenshots below.

Before After
Pasted image 20240922225036 Pasted image 20240922225435
Pasted image 20240922225030 Pasted image 20240922225105

I foresee this change being made across the codebase shortly
and want to proactively prevent my PR from falling behind
@taffyko taffyko requested a review from a team as a code owner October 22, 2024 21:46
@CLAassistant
Copy link

CLAassistant commented Oct 22, 2024

CLA assistant check
All committers have signed the CLA.

res/css/views/rooms/_EventTile.pcss Outdated Show resolved Hide resolved
res/themes/dark/css/_dark.pcss Outdated Show resolved Hide resolved
src/components/views/messages/TextualBody.tsx Outdated Show resolved Hide resolved
It is clear that it would be best for me to address
this piece in a separate PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications triggered by keywords don't decorate messages - Highlight keywords in a pill
3 participants