fix: support esm entrypoints for asar shim #101
Draft
+125
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90
In cases where two ASAR archives or app folders are created, we create a new
index.js
shim that points to the correct entrypoint depending on the host system's architecture.This
index.js
shim was originally written in CommonJS, making it incompatible with Electron apps using ESM entrypoints, which are available starting in Electron 28.This PR does a few things:
entry-asar/index.js
shim.type: module
ormain:*.mjs
in package.json, then copies over the ESM or CJS shim accordingly.tsconfig.json
refactoring to supportentry-asar
having different compilation targets.