Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Petal freq shifter #91

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Petal freq shifter #91

wants to merge 7 commits into from

Conversation

beserge
Copy link
Contributor

@beserge beserge commented Aug 14, 2020

No description provided.

@stephenhensley
Copy link
Collaborator

stephenhensley commented Aug 17, 2020

Quicknotes (the first few things are pretty much just related to the pitchshifter module itself:

  • LFO values end up getting quantized to semitones (which actually seems like part of pitchshifter.h SetTransposition) --
  • disabling the quantization in pitchshifter causes clicks (sounds like its when the lfos flip to reverse or something else.
  • Might as well add a knob for the del-size which is basically a quality vs accuracy scalar that changes the timbre (snippet below)
  • Same note as before about Process and UpdateAnalogControls conflict
  • Same note as before about Parameter vs AnalogControl consistency, and mixing between the UpdateControls and Audio Callback (which with these examples so far have been short enough that they don't need to be abstracted away).
  • Squaring (exponential curve) for the amplitude of the pitchshifter LFO feels more expressive when pitchshifter is unquantized.
  • Make it stereo! (once the other stuff is polished of course).
  • Botttom most of pitch control actually goes through zero and back up to one octave (I think the scaling for pitch shifting down calculations is off by a factor of two)
  • Missing petal.UpdateLeds()
// In global/static space -- feel free to use Parameter class
static float delsize;
// Delay size setter - in callback within sample-loop (for smoothness)

fonepole(delsize, 256 + (petal.knob[5].Value() * (SHIFT_BUFFER_SIZE - 256)), 0.001f);
// AT 256 it will respond quickly, but will not represent very accurate pitches.
// at SHIFT_BUFFER_SIZE - will respond less quickly (semi-audible delay on signal), but will be able to more accurately represent the original pitch.

@stephenhensley
Copy link
Collaborator

There might be some more work involved, if you feel like poking around the pitchshifter to resolve some of this stuff, the paper I used to write it is linked in the header file.

@corellmichael
Copy link
Collaborator

corellmichael commented Oct 2, 2020

Notes

  • Switch 1 LED does not illuminate when effect is ON.

  • LFO steps are more noticeable at lower frequency rates, if its possible to smooth out the LFO it would be perfect.

Other than that and what Shensley has mentioned, this effect is solid.

@corellmichael
Copy link
Collaborator

Petal Comb FIlter

@beserge
Copy link
Contributor Author

beserge commented Nov 9, 2020

TODO: some crunch when adjusting delsize, get rid of quantization (DaisySP)

@stephenhensley
Copy link
Collaborator

Marking as draft due to inactivity.

@stephenhensley stephenhensley marked this pull request as draft December 1, 2021 16:54
hyrfilm pushed a commit to hyrfilm/DaisyExamples that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants