-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Align Lens style with Borealis #204839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ Adding an early review due to upcoming PTO.
...es/kbn-coloring/src/shared_components/color_mapping/components/color_picker/color_picker.tsx
Outdated
Show resolved
Hide resolved
.../kbn-coloring/src/shared_components/color_mapping/components/color_picker/palette_colors.tsx
Outdated
Show resolved
Hide resolved
packages/kbn-visualization-ui-components/components/dimension_buttons/dimension_button.tsx
Outdated
Show resolved
Hide resolved
.../lens/public/datasources/form_based/operations/definitions/formula/editor/formula_editor.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/lens/public/editor_frame_service/editor_frame/config_panel/layer_panel.tsx
Outdated
Show resolved
Hide resolved
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked locally and works fine.
It matches all the requested changes.
no fontsize change applied
fd3ebde
to
3192c14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together, @markov00. It looks great. I left a few small comments below. Once those are addressed, I think this is good to go.
.../kbn-coloring/src/shared_components/color_mapping/components/color_picker/palette_colors.tsx
Outdated
Show resolved
Hide resolved
.../kbn-coloring/src/shared_components/color_mapping/components/color_picker/palette_colors.tsx
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-dom-drag-drop/src/sass/drag_drop_mixins.scss
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-dom-drag-drop/src/sass/drag_drop_mixins.scss
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-dom-drag-drop/src/sass/droppable.scss
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-dom-drag-drop/src/sass/drag_drop_mixins.scss
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-dom-drag-drop/src/sass/drag_drop_mixins.scss
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-dom-drag-drop/src/sass/droppable.scss
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-dom-drag-drop/src/sass/droppable.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for making those changes, @markov00!
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
|
## Summary This PR updates the style of Lens to align it with the new Borealis theme. It covers the set of tasks in elastic#203050 within the `Lens editor panels` list. Comments are applied in order as in the mentioned issue --------- Co-authored-by: kibanamachine <[email protected]>
## Summary This PR updates the style of Lens to align it with the new Borealis theme. It covers the set of tasks in elastic#203050 within the `Lens editor panels` list. Comments are applied in order as in the mentioned issue --------- Co-authored-by: kibanamachine <[email protected]>
Summary
This PR updates the style of Lens to align it with the new Borealis theme.
It covers the set of tasks in #203050 within the
Lens editor panels
list.Comments are applied in order as in the mentioned issue