Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Align Lens style with Borealis #204839

Merged
merged 18 commits into from
Jan 9, 2025

Conversation

markov00
Copy link
Member

Summary

This PR updates the style of Lens to align it with the new Borealis theme.
It covers the set of tasks in #203050 within the Lens editor panels list.

Comments are applied in order as in the mentioned issue

@markov00 markov00 added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This commit does not require backporting v9.0.0 EUI Visual Refresh labels Dec 18, 2024
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Adding an early review due to upcoming PTO.

@markov00 markov00 marked this pull request as ready for review January 8, 2025 10:42
@markov00 markov00 requested review from a team as code owners January 8, 2025 10:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked locally and works fine.
It matches all the requested changes.

@markov00 markov00 force-pushed the 2024_12_16-align_borealis branch from fd3ebde to 3192c14 Compare January 8, 2025 14:26
@markov00 markov00 requested a review from a team as a code owner January 8, 2025 14:26
Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together, @markov00. It looks great. I left a few small comments below. Once those are addressed, I think this is good to go.

Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for making those changes, @markov00!

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #18 / CasesWebhookActionConnectorFields renders Validation validates correctly "webhookCreateUrlText"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 785.0KB 784.9KB -27.0B
eventAnnotationListing 231.0KB 230.9KB -106.0B
lens 1.5MB 1.5MB +949.0B
securitySolution 22.2MB 22.2MB -27.0B
total +789.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/coloring 2 3 +1

Total ESLint disabled count

id before after diff
@kbn/coloring 2 3 +1

History

@markov00 markov00 merged commit 75a401f into elastic:main Jan 9, 2025
9 checks passed
Zacqary pushed a commit to Zacqary/kibana that referenced this pull request Jan 9, 2025
## Summary

This PR updates the style of Lens to align it with the new Borealis
theme.
It covers the set of tasks in elastic#203050 within the `Lens editor panels`
list.

Comments are applied in order as in the mentioned issue

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
## Summary

This PR updates the style of Lens to align it with the new Borealis
theme.
It covers the set of tasks in elastic#203050 within the `Lens editor panels`
list.

Comments are applied in order as in the mentioned issue

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting EUI Visual Refresh Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants