Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Teleport] Update based on internal feedback #11791

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[Teleport] Update based on internal feedback #11791

wants to merge 2 commits into from
+113 −13

Conversation

ilyannn
Copy link
Contributor

@ilyannn ilyannn commented Nov 20, 2024 •
edited
Loading

Proposed commit message

Resolves the issues found when the Teleport integration was reviewed internally:

  • Fix teleport.audit.kubernetes.groups and similar feld type
  • Handle situation when host.name already exists

We also implement the following quality-of-life improvements:

  • Added tags and descriptions for processors.
  • Switched to append processors instead of rename wherever fields from different groups may collide.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ilyannn ilyannn added bug Something isn't working, use only for issues enhancement New feature or request labels Nov 20, 2024
@ilyannn ilyannn self-assigned this Nov 20, 2024
@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Integration:teleport Teleport and removed bug Something isn't working, use only for issues labels Nov 20, 2024
@elasticmachine
Copy link

elasticmachine commented Nov 20, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @ilyannn

@ilyannn ilyannn changed the title [Teleport] Apply feedback [Teleport] Fixes from the internal feedback Nov 20, 2024
@ilyannn ilyannn changed the title [Teleport] Fixes from the internal feedback [Teleport] Update based on internal feedback Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ilyannn ilyannn

Labels
bugfix Pull request that fixes a bug issue enhancement New feature or request Integration:teleport Teleport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilyannn @elasticmachine @andrewkroh