Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azure/graphactivitylogs] fix destination.geo.region_name mapping #11749

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[azure/graphactivitylogs] fix destination.geo.region_name mapping #11749

wants to merge 4 commits into from
+9 −1

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Nov 14, 2024 •
edited
Loading

Proposed commit message

This PR is to add destination.geo.region_name mapping into ecs.yml to fix error:

object mapping for [destination.geo.region_name] tried to parse field 
[region_name] as object, but found a concrete value\"}, dropping event!"

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review November 14, 2024 18:30
@kaiyan-sheng kaiyan-sheng requested review from a team as code owners November 14, 2024 18:30
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 14, 2024 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Integration:azure Azure Logs Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Nov 18, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@kaiyan-sheng
Copy link
Contributor Author

/test

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

muthu-mps
muthu-mps approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code owner approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muthu-mps muthu-mps muthu-mps approved these changes

@gizas gizas gizas approved these changes

@zmoog zmoog zmoog approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bugfix Pull request that fixes a bug issue Integration:azure Azure Logs Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kaiyan-sheng @elasticmachine @zmoog @gizas @muthu-mps @andrewkroh