Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix positive infinity unmarshalling #727

Closed
wants to merge 1 commit into from

Conversation

xlucas
Copy link

@xlucas xlucas commented Sep 28, 2023

Unfortunately #715 contained a subtle error because the representation of positive infinity in JSON as returned by Elasticsearch is "Infinity" and not "+Infinity".

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Sep 28, 2023

💚 CLA has been signed

@xlucas xlucas force-pushed the infinity-unmarshalling-fix branch from 9dda2c9 to f3900df Compare September 28, 2023 16:13
@xlucas xlucas marked this pull request as ready for review September 28, 2023 16:13
@Anaethelion Anaethelion self-requested a review October 10, 2023 14:26
@Anaethelion
Copy link
Contributor

Hi! Thank you for the report, I've fixed this in #731

@xlucas xlucas deleted the infinity-unmarshalling-fix branch October 13, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants