Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visual Refresh] Update floating border on EuiPanel #8270

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Jan 13, 2025

Summary

Important

This PR merges into a feature branch.

This PR updates the implementation of the floating border on EuiPanel to fix the issue of the transparent border on light mode showing with colored full-width content (e.g. for EuiSplitPanel)

Instead of adding the floating border on the panel element directly, this PR adds a pseudo element for the border.
This will:

  • prevent transparent borders from showing as the border overlaps the content instead of sitting around the content
  • ensures layout parity between light and dark mode (having a conditional border on dark mode would otherwise mean that light and dark mode have slightly different dimensions for panels as borders add to the size)
before after
Screenshot 2025-01-13 at 10 52 52 Screenshot 2025-01-13 at 10 53 31

QA

Note

To enable Borealis in EUI PR deployments, you'll need to:

  • add the following localStorage item: eui-experimental-theme-enabled: true
  • reload the page
  • select Borealis from the theme switcher
  • verify the floating border on EuiSplitPanel (Storybook, EUI docs) is visible for Borealis only
  • verify the border does not affect dimensions between light and dark mode
  • verify panels look the same between production and staging

@mgadewoll mgadewoll self-assigned this Jan 13, 2025
@mgadewoll mgadewoll marked this pull request as ready for review January 13, 2025 10:54
@mgadewoll mgadewoll requested a review from a team as a code owner January 13, 2025 10:54
- prevents transparent borders showing on colored full-width content, e.g. for EuiSplitPanel
@mgadewoll mgadewoll force-pushed the eui-theme/panel-floating-border-fix branch from 2168cd7 to 11d4754 Compare January 13, 2025 15:47
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 13, 2025

💚 Build Succeeded

History

cc @mgadewoll

@weronikaolejniczak
Copy link
Contributor

weronikaolejniczak commented Jan 14, 2025

LGTM 👍🏻 Great job, Lene!

Testing

Storybook (Borealis)

Screen.Recording.2025-01-14.at.12.01.33.mov

Storybook (Amsterdam)

Screen.Recording.2025-01-14.at.12.05.00.mov

EUI Docs (Borealis)

Screen.Recording.2025-01-14.at.12.03.45.mov

EUI Docs (Amsterdam)

Screen.Recording.2025-01-14.at.12.06.13.mov
Screen.Recording.2025-01-14.at.12.15.02.mov

Production vs Staging (Amsterdam)

Screen.Recording.2025-01-14.at.12.06.13.mov
Screen.Recording.2025-01-14.at.12.13.09.mov

@mgadewoll mgadewoll merged commit 100d15e into elastic:eui-theme/borealis Jan 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants