Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add const keyword to CrossSection::Compose parameter #1129

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

tomasf
Copy link
Contributor

@tomasf tomasf commented Dec 30, 2024

Add a missing const to the crossSections parameter ofCrossSection::Compose.

Copy link

google-cla bot commented Dec 30, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (1b3dbc2) to head (ba69f68).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1129   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files          30       30           
  Lines        5915     5915           
=======================================
  Hits         5417     5417           
  Misses        498      498           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elalish elalish merged commit ae813dd into elalish:master Dec 30, 2024
28 checks passed
@tomasf tomasf deleted the compose-const branch December 30, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants