Skip to content

Commit

Permalink
python: add ninja build dependency (#1128)
Browse files Browse the repository at this point in the history
* python: add ninja build dependency

* change ninja version setting

* CI: install ninja for SDist

* fix package name
  • Loading branch information
pca006132 authored Dec 29, 2024
1 parent 98b8142 commit 1b3dbc2
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/build_wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,11 @@ jobs:
- name: Build SDist
run: pipx run build --sdist
- name: Confirm SDist can be built
run: pip wheel dist/*.tar.gz
run: |
# FIXME: why doesn't scikit_build_core automatically download ninja?
sudo apt-get update
sudo apt-get install ninja-build
pip wheel dist/*.tar.gz
- uses: actions/upload-artifact@v4
with:
name: python-sdist
Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ requires = [
build-backend = "scikit_build_core.build"

[tool.scikit-build]
cmake.minimum-version = "3.18"
cmake.version = ">=3.18"
ninja.version = ">=1.11"
sdist.exclude = [
".github",
"bindings/c",
Expand Down

0 comments on commit 1b3dbc2

Please sign in to comment.