Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add diff created by running make build #8121

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

bryantbiggs
Copy link
Member

Description

  • Add diff created by running make build

You can reproduce this on main by:

  1. make clean
  2. make install-build-deps
  3. make build

You should see the same diff as shown in this PR

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC added the skip-release-notes Causes PR not to show in release notes label Jan 9, 2025
@TiberiuGC TiberiuGC enabled auto-merge (squash) January 10, 2025 11:05
@TiberiuGC TiberiuGC merged commit 6444622 into eksctl-io:main Jan 10, 2025
9 checks passed
@bryantbiggs bryantbiggs deleted the chore/build branch January 10, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants