Move IAM Service Account Tasks to actions package #7140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TiberiuGC
added
the
area/tech-debt
TiberiuGC
force-pushed
the
maintenance/move-iam-sa-related-tasks
branch
from
d3fd457 to
5dc91f9
Compare
TiberiuGC
force-pushed
the
maintenance/move-iam-sa-related-tasks
branch
from
5dc91f9 to
e10ecfe
Compare
TiberiuGC
commented
Oct 17, 2023
| errMsg := fmt.Sprintf("deleting addon IAM %q", *t.stack.StackName) | ||
| if t.wait { | ||
| if err := t.stackManager.DeleteStackBySpecSync(t.ctx, t.stack, errorCh); err != nil { | ||
| return fmt.Errorf("%s: %w", errMsg, err) | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| defer close(errorCh) |
There was a problem hiding this comment.
Closing error channel to early here was nullifying the effect of the --wait flag
There was a problem hiding this comment.
It actually introduced a bug - #7177. Going to address it in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #6961
Migrates IAM service account create/delete tasks to the
actions/irsapackage, reducing the complexity of StackManager interface used for defining interactions with CFN API.Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯