Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for creating Scheduled Scaling rules using eksctl CLI #6732

Closed

Conversation

hassaanakram
Copy link
Contributor

Description

AWS EKS NodeGroups are bound to Autoscaling groups that support AWS::AutoScaling::ScheduledAction which allows the user to create NodeGroup scaling rules for predictable load changes. Currently, eksctl does not support the creation of ScheduledAction. This PR introduces the Scheduled Scaling feature.

Closes #5524

Method

The AWS::AutoScaling::ScheduledAction can be created after an ASG is created therefore this has been added a new sub task in Unmanaged and Managed NodeGroup creation tasks.

Note

This is a draft PR and does not contain updates to test files.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@hassaanakram
Copy link
Contributor Author

Hi @Himangini
can i continue working on this? Can you please have a look at my comment in the attached issue

@TiberiuGC TiberiuGC added area/autoscaler kind/feature New feature or request stale and removed stale labels Sep 8, 2023
@Himangini Himangini removed the stale label Sep 8, 2023
@TiberiuGC
Copy link
Collaborator

Hi @hassaanakram

I like your approach using a new stack. You may carry on the work whenever you find convenient. Only comment is I think we also need to delete these stacks when deleting nodegroups.

@github-actions github-actions bot added the stale label Oct 21, 2023
@github-actions github-actions bot closed this Oct 27, 2023
@TiberiuGC TiberiuGC removed the stale label Oct 27, 2023
@TiberiuGC TiberiuGC reopened this Oct 27, 2023
@github-actions github-actions bot added the stale label Nov 27, 2023
@github-actions github-actions bot closed this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] EKSCTL can create scheduled scaling rules
3 participants