feat: properties, refactors, and cloudformation stack cleanup #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying aws-nuke with
|
| Latest commit: |
3d90281
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c68d10fb.aws-nuke.pages.dev |
| Branch Preview URL: | https://jan2025-improvements.aws-nuke.pages.dev |
…nto jan2025-improvements * 'jan2025-improvements' of github.com:ekristen/aws-nuke: docs(resources): auto-generated test(cloudwatchlogs-loggroup): add property test coverage feat(cloudwatchlogs-loggroup): new properties, refactor properties struct refactor(cloudwatchlogs-loggroup): standardization fix(cloudwatchlogs-loggroup): property RetentionInDays should always have a value feat(cloudwatchlogs-loggroup): add RetentionInDays properties fix(deps): update module github.com/aws/aws-sdk-go-v2/service/s3 to v1.72.0
|
🎉 This PR is included in version 3.42.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The main change in this PR is to the
CloudFormationStackto add the new settingCreateRoleToDeleteStack.If the a CloudFormationStack has a role associated but it gets deleted first it can cause the CloudFormationStack to error when trying to delete, therefore a new feature has been introduced to allow the re-creation of the role by aws-nuke. Once created, the deletion should succeed, and then the role cleaned up.
Additional Changes
New Resources
Removed Resources
References