feat: add cloudfront cache policy resource #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 3.0.0-beta.40 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Love the cherry pick to preserve contribution credit! |
|
Thanks. Trying to keep credit where credit is due when I'm not the primary repo. |
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds the cloudfront cache policy by way of cherry picked commit from @MikeSchouw and their upstream branch based on this PR rebuy-de/aws-nuke#1152
Rebased the original commit to turn the commit into semantic commit message format, but preserve Mike's contributions as much as possible. Converted to the libnuke resource format and add a nolint statement for golangci-lint to ignore.
Resolves #135
Upstream References