Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iot-thinggroups): support deleting dynamic thing groups #124

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

ekristen
Copy link
Owner

Attempts to fix deleting dynamic thing groups which was brought up rebuy-de/aws-nuke#1199.

Creating dynamic thing groups are bit more complicated so this is tough to test.

@ekristen
Copy link
Owner Author

ekristen commented Mar 15, 2024

@rstalbow can you test one of the builds from the zip file located here? https://github.com/ekristen/aws-nuke/actions/runs/8291642110/artifacts/1328506343

This is my rewrite of aws-nuke that I've been working on. docs and reason for why the rewrite is here If you modify your configuration to target just IoTThingGroup then you can specifically test this without affecting anything else.

If you'd like to help test this version out, I would appreciate it, but if not, I understand.

This is an example configuration you can use, this makes use of the a feature from my fork that does dynamic region discovery, feel free to replace - all with your specific regions.

regions:
  - all

blocklist:
  - "123456789012"

accounts:
  "123456789012": {}

resource-types:
  includes:
    - IoTThingGroup
aws-nuke run --config example.yaml

You should see output similar to this.

> aws-nuke - 3.0.0-dev - dirty
Do you really want to nuke the account with the ID 123456789012 and the alias 'no-alias-123456789012'?
Waiting 3s before continuing.
us-east-1 - IoTThingGroup - test - [Name: "test", Type: "static"] - would remove
us-east-1 - IoTThingGroup - test1 - [Name: "test", Type: "dynamic"] - would remove
Scan complete: 2 total, 2 nukeable, 0 filtered.

@ekristen ekristen merged commit baf9f62 into main Mar 27, 2024
4 checks passed
@ekristen ekristen deleted the fix-iot-dynamic-thing-groups branch March 27, 2024 15:36
@ekristen
Copy link
Owner Author

🎉 This PR is included in version 3.0.0-beta.38 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rstalbow
Copy link

Great! Sorry I didnt get a chance to test the build

@ekristen
Copy link
Owner Author

Feel free to test now and let me know if you run into issues

@ekristen
Copy link
Owner Author

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants